Skip to content

[Forwardport] Link logo in web setup wizard to back-end base URL#17610

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
arnoudhgz:2.3-develop-PR-port-17543
Aug 16, 2018
Merged

[Forwardport] Link logo in web setup wizard to back-end base URL#17610
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
arnoudhgz:2.3-develop-PR-port-17543

Conversation

@arnoudhgz
Copy link
Copy Markdown
Contributor

@arnoudhgz arnoudhgz commented Aug 14, 2018

Original Pull Request

#17543

Description

When you get to the web setup wizard from the Magento back-end it was not possible to get back to the back-end from this page.

This commit makes the logo clickable and when you click it you will return the Magento back-end.

Fixed Issues (if relevant)

  1. Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard #13948:
    Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard
  2. ...

Manual testing scenarios

  1. Admin dashboard > System > Web Setup Wizard
  2. Click Magento logo on top left
  3. You get back to admin dashboard

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@arnoudhgz
Link logo in web setup wizard to back-end base URL
43bbdb5 
When you get to the web setup wizard from the Magento back-end it was
not possible to get back to the back-end from this page.

This commit makes the logo clickable and when you click it you will
return the Magento back-end.
@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend Component: Setup Release Line: 2.3 labels Aug 14, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 14, 2018

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov mentioned this pull request Aug 14, 2018
Closed
4 tasks
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 15, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Aug 16, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 43bbdb5 into magento:2.3-develop Aug 16, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 16, 2018
ENGCOM-2796: [Forwardport] Link logo in web setup wizard to back-end …
aff0142 
…base URL #17610
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Aug 16, 2018

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sidolov sidolov

Labels

Area: Design/Frontend Component: Setup Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@arnoudhgz @magento-engcom-team @sidolov